78rpm EQ Curve Generator

Looks like we’re good to go with the validator. https://forum.audacityteam.org/t/could-someone-test-this-on-mac-and-windows-please-solved/22956/1
Just need to fit it into the “Save File” function now.

Neither do I, but although “/” is the file separator on Mac it is translated internally by the OS so should be accepted. You can save a filename including forward slash in Save or Export in Audacity (not export multiple).

Why do you have (string-search “>” fname) twice in the Windows exceptions?




Gale

Thanks Gale, I didn’t know that.
Has the current 78rpm EQ Curve Generator been tested with a “/” in the file name?
If it’s confirmed that Nyquist can save files that contain a “/” in the name then I’ll change the validator function.


That’s an error (though a harmless one). I’ll fix that now. [Update: fixed]

Just heard from Bill who has confirmed that files with a “/” in the file name do gets saved with the “/” in the file name (the forward slash is not interpreted as a directory level and the Mac does not attempt to translate it).

Got the “write to file” function done: https://forum.audacityteam.org/t/write-text-file-cross-platform-compatible/22981/1
I think that it includes all of the error checking of your original code POL, (let me know if I’ve missed anything out), plus file name verification.
Hopefully not too many errors - just needs testing now.

I think it should be pretty easy to adapt the function to suit the 78rpm EQ Curve Generator (assuming you’d like the extra error checking).
I just wish the code was a bit shorter :unamused:

There’s a bug in “78rpm EQ Curve Generator” that we’d missed.

On Windows, if the output path is set to “D:” the path is not found.
(Thanks to Edgar for spotting the same problem in writefile.ny)

The problem is that if the working directory is a drive letter, then (setdir “.”) returns the path with a “” at the end, whereas for all other paths there is no “” at the end.

I think I did notice this before, though I am not going to search for the topic to prove it. In fact I specifically tested this time to see if it was fixed. From what I recall, this wasn’t easy to fix?


Gale

And it’s not fixed is it?

I don’t see a “neat” fix for it.
It’s a Windows specific inconsistency, so we’ll need to conditionally test for Windows, then test for if the path is a drive letter, and balance up the file separators if it is.

I’ve already got a test for Windows in the new “write-to-file” function (thanks to Edgar-rtf for that), so we can use something like:

(if (and (windowsp)(= (length (setdir ".") 3))) ..... )

to test for it.

The code could be soooo much simpler if we didn’t need to support Windows :smiley:

No, on Win XP (real machine).

Where would be the best place to slot that into writefile.ny?


Gale

Thanks for the confirmation.

It looks like there is a neater way.

At around line 98 in writefile.ny

  ;; Test if path is working directory
  (unless (or (equal path (setdir "."))
              ;; allow for Windows inconsistencies
              (and (windowsp)
                   (string-equal path (string-right-trim slashstring (setdir ".")))))
    (setq warn (format nil "Output folder "~a~a" cannot be found~%" 
                (string-right-trim slashstring path) slashstring))
    (setq path (home)) ;fall back to Home folder
    (setdir path))

Too late at night for me to test this properly, I’ll have another look tomorrow.

And the user population would be soooo much smaller :smiley: :smiley:

Sad but true.

This should now be fixed in writefile.ny.

@Irish: What do you think about using this write-to-file function in your 78rpm EQ Curve Generator?
(It’s not yet been tested on Mac, so that needs to be done first)

Hello,
I find this plugin very useful for remastering old 78 records. Especially “cancel RIAA” option in ver.2. Unfortunately, in later versions this feature is not available. I understand, that it’s possible to use “invert RIAA”. But I think it’s more convenient to do everything in one step.
My questions are the following. Is it OK to use ver.2 (small bugs for me not a problem)? Or I have to use the latest ver.2_7?
Thanks a lot for the valuable help!

If you are referring to Audacity versions, the current version is 2.4.2 Audacity ® | Downloads

This is an ancient forum topic and lots has changed in the past 10 years. The “78EQCurveGen.ny.zip” plug-in is not directly compatible with recent versions of Audacity because the Equalization effect has been replaced by “Filter Curve Eq”. However, there is tool included with Audacity 2.4.2 to convert the old Equalization curves to the new format used by Filter Curve Eq: EQ XML to TXT Converter - Audacity Manual

Thank you very much for the answer. I mean ver. 2 of “78EQCurveGen.ny” plug-in. I checked it with Audacity 2.4.2. It works fine. Of course, I have to convert XML to TXT before apply to wav.

I just want to know which version of plug-in shall be used to generate XML curve. I prefer ver.2 because it has option to remove RIAA in one step of Equaliztion. But I find the latest version 2_7 doesn’t has this option.

For example I need curve for Deutche Grammophon record from 1928. According to the table in Missing features - Audacity Support the turnover is 300 and roll-off -5. I can generate curve, convert it to txt and apply.

The only question is about the right (in terms of EQ curve) version of plug-in .

Thank you!

The only question is about the right (in terms of EQ curve) version of plug-in .

I’ve never digitized a 78, but…

The playback equipment in 1928 wasn’t exactly “high fidelity” and you were stuck with whatever gramophone you had so it didn’t necessarily match the EQ on particular record. (And of course the recording equipment wasn’t that great either.)

So whatever you’re hearing isn’t what would have been heard on the gramophone and most likely you’re not hearing it “as intended”.

So my point is… Don’t be afraid to tweak the EQ by-ear!



…I heard a mechanical wind-up gramophone a few years ago. It was a cabinet model and it didn’t have the “classic” horn on top so I assume the horn was a wood horn built-into the cabinet. It had surprisingly good “tone” and surprising volume for something with no electronics inside! I’m not saying it sounded “good” but it sounded better than the 78s I’ve heard on more modern equipment. (It might have been a “newer” 78 from the 1950s in excellent condition.)

Thank you very much for your answer. I think the same way. The question is about the point to start. The good idea to start with the original sound that was recorded. To do that we have to restore the original recording curve.
I checked curves generated by plug-in from ver.2 to ver.2_7. They are about the same. The small difference after dot doesn’t matter. I have decided to use ver.2 because it’s possible to convert directly from RIAA in one step

Thanks for everybody!

Here is the example of the restored Deutsche Grammophon record was issued in 1928 year
https://drive.google.com/file/d/1hPdvqbgycCfDrKQSOIwoxEEncz70oan9/view