Improved seeking

[Robert J. H.]

Gale, here are the steps:

- create a chirp tone
- hold down dot (.) or shift-dot until you shoot over the right boundary
- The play cursor/ selection moves to the end of the track or nearly so.
- try different selections and movement keys.

Audacity 2.0.7 alpha Rev 13536 (with the second patch applied), Host Wasapi.

[steve]

Robert, can you please write steps out 1,2,3 for the bug. I can't understand exactly what you mean.

I don't either.

hold down dot (.) or shift-dot until you shoot over the right boundary

It doesn't shoot over the right boundary. It stops at the end

The play cursor/ selection moves to the end of the track or nearly so.

On my machine, it stop at the end of the final sample period.

try different selections and movement keys.

"Shift + dot" does the same.
"K" does the same.
"End" does the same.

What happens for you?

[Robert J. H.]

What happens for you?

The audio is playing until the end is reached.
All following keys are interpreted as their counterpart in stop mode.
This means that the cursor will be moved from now on, either from its original position or the right selection boundary.
In other words, the holding down of the key seems to be interrupted at the end and resumed which leads to that odd behaviour.
I suspect that it is somehow caused by the screen reader. That would explain why you do not have this problem.
The issue remains if I quit NVDA, but disappears after a restart of NVDA, i.e. the selection is not altered anymore.
I hope it stays like that.

Another oddity: When I hold point (. down in order to seek and press at the same time space (to stop playback), Audacity crashes (but who does such a thing...).

[Gale Andrews]

What happens for you?

The audio is playing until the end is reached.
All following keys are interpreted as their counterpart in stop mode.
This means that the cursor will be moved from now on, either from its original position or the right selection boundary.
In other words, the holding down of the key seems to be interrupted at the end and resumed which leads to that odd behaviour.
I suspect that it is somehow caused by the screen reader. That would explain why you do not have this problem.
The issue remains if I quit NVDA, but disappears after a restart of NVDA, i.e. the selection is not altered anymore.
I hope it stays like that.

I can reproduce that issue without NVDA on, but only in the patched build.

1. Generate Tone 5 minutes, place cursor at 10s, press and release SPACE, hold down period (dot).
2. When the playback stops, the editing cursor moves from 10s to the end of the track then stops there.
3. Select from e.g. 1 minute to the end, press and release SPACE, hold down period (dot).
4. When the playback stops, the editing cursor moves from 10s to the end of the track then stops there, removing the selection.

Mouse up after CTRL-dragging to scrub removes the selection. I told Paul I don't like that, as you may have seen on -devel.

When I hold point (. down in order to seek and press at the same time space (to stop playback), Audacity crashes (but who does such a thing...).

I can reproduce that in HEAD on Windows and Mac (but not on Linux) so I made a P4 bug for it: Bug 781 – Crash pressing SPACE while holding down short seek shortcut.


Gale

[Paul L]

I'm on the case! I reproduced it in Windows, and it was like something I had seen before but not with the unmodified source tree. I uploaded a patch to Bugzilla. Thanks to Robert and Gale for a proof that this crash was not a result of any change of mine.

[Paul L]

... and James has committed my fix.