Potential compiler failure

Building and customizing Audacity from the source code.
Forum rules
If you require help using Audacity, please post on the forum board relevant to your operating system:
Windows
Mac OS X
GNU/Linux and Unix-like
Post Reply
Edgar
Forum Crew
Posts: 2043
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 10

Potential compiler failure

Post by Edgar » Mon Sep 29, 2014 6:19 am

In the source file: srcexportExportFLAC.cpp at or near line number 240:

Code: Select all

#ifdef LEGACY_FLAC
   encoder.set_filename(OSOUTPUT(fName));
#endif
If LEGACY_FLAC somehow gets set, the above will fail to compile because the function:

Code: Select all

encoder.set_filename(…)
does not exist. Have a look at: lib-srclibflacincludeFLAC++encoder.h between lines 127 & 149 where all of the set… () functions are listed– it is not there.

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Potential compiler failure

Post by steve » Mon Sep 29, 2014 9:28 am

It looks to be very old cruft (circa 2006). If it is to be cleaned up, then there is also:
#if !defined FLACPP_API_VERSION_CURRENT || FLACPP_API_VERSION_CURRENT < 6
in a couple of places.
The version that we are currently using appears to be 9
(line 60 export.h)

Post Reply