Updated De-Clicker and new De-esser for speech

[Gale Andrews]

If anyone knows the default numbers top to bottom, Id dig you!!

Trebor showed you the default values, but it is easy to get back to the defaults if you need to. Click the "Manage" button, expand "Factory Presets" then click "Defaults".


Gale

[Trebor]

... it is easy to get back to the defaults if you need to. Click the "Manage" button, expand "Factory Presets" then click "Defaults".

Since 2-1-3 I get an error message when clicking the default on Paul-L's DeClicker :
it attempts to load the settings from a compressor plugin ...

DeClicker error message when default selected (since V2-1-3).png (22.21 KiB) Viewed 1847 times

If you've adjusted the DeClicker from the default settings, those settings persist during that session of Audacity when you try to return to default settings. The default settings only return after restarting Audacity.

[steve]

Since 2-1-3 I get an error message when clicking the default on Paul-L's DeClicker :

Click "OK" in that dialog, and run the effect.
Now open the effect again - do you still get that message?

[Gale Andrews]

... it is easy to get back to the defaults if you need to. Click the "Manage" button, expand "Factory Presets" then click "Defaults".

Since 2-1-3 I get an error message when clicking the default on Paul-L's DeClicker :
it attempts to load the settings from a compressor plugin ...

It does not happen to me on Windows 10. You may need to exit Audacity and delete pluginsettings.cfg, and perhaps delete pluginregistry.cfg as well (especially if you have multiple copies of the shipped Audacity plugins in the Effect Menu).


Gale

[Trebor]

Click "OK" in that dialog, and run the effect.
Now open the effect again - do you still get that message?

Clicking "OK" doesn't make any difference : the default setting is not applied ...

click on this animation to see it in its entirety

DeClicker error message when default selected.gif (254.45 KiB) Viewed 1848 times

[Trebor]

... delete pluginsettings.cfg ...

That's fixed it , (but that does also delete all the presets for the other plugins).

[steve]

I've an idea what may be happening.
@Trebor, could you try this test to see if it causes similar symptoms.

Here are two versions of a very simple 'effect' plug-in. It just tells you what value you selected.
Both plug-ins have the same name and the same file name, so you'll need to keep careful track of which is which.

AAAtest.ny

AAA Test version 1

(236 Bytes) Downloaded 69 times

AAAtest.ny

AAA Test version 2

(241 Bytes) Downloaded 64 times

Install "version 1" and run it.
Close Audacity.
Replace the "version 1" file with the "version 2" file.
Restart Audacity and re-test the plug-in.

[Trebor]

@Trebor, could you try this test to see if it causes similar symptoms.

"AAA Test version 1 (236 Bytes)" no error message , default setting (5) works.

"AAA Test version 2 (241 Bytes)" generates this error message when selected from menu ...

error message.png (6.33 KiB) Viewed 1846 times

same error message shown when selecting default on version 2.

So that looks like the same type of fault as was happening with Paul-L's DeClicker (& DeEsser).

[Gale Andrews]

I get the error on first launch of the replaced AAAtest about not being able to load the setting of "5", but that part seems totally expected to me. That error only appears once.

The error clicking on defaults is repeatable, so I guess the issue is that Audacity does not check to see if the defaults actually changed and if so update the defaults.

Code: Select all

[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=]
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=/private]
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=/private/FactoryDefaults]
Parameters=val="5.000000000000"
Initialized=1
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=/private/CurrentSettings]
Parameters=val="0.500000000000"

It should be:

Code: Select all

pluginsettingsversion=1.0
[pluginsettings]
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=]
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=/private]
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=/private/FactoryDefaults]
Parameters=val="0.500000000000"
Initialized=1
[pluginsettings/base64\:RWZmZWN0X055cXVpc3RfU3RldmUgRGF1bHRvbl9BQUEgVGVzdA\=\=/private/CurrentSettings]
Parameters=val="0.500000000000"

In Trebor's original case, pluginsettings.cfg seemed to be reading settings from another effect. If you were careful, it would have been possible just to delete that one bad entry in pluginsettings.cfg, but users should not be expected to have to do that.


Gale

I've an idea what may be happening.
@Trebor, could you try this test to see if it causes similar symptoms.

Here are two versions of a very simple 'effect' plug-in. It just tells you what value you selected.
Both plug-ins have the same name and the same file name, so you'll need to keep careful track of which is which.

AAAtest.ny

AAAtest.ny

Install "version 1" and run it.
Close Audacity.
Replace the "version 1" file with the "version 2" file.
Restart Audacity and re-test the plug-in.

[steve]

I guess the issue is that Audacity does not check to see if the defaults actually changed and if so update the defaults.

It doesn't, and what's worse, it retains the default setting even if the plug-in is removed (either via the Plug-in manager, or physically removed).

A possible fix might be to unset the "initialized" token when a plug-in is removed, or 'missing'. This could allow the last used and custom presets to be retained in case the plug-in is added back later, but would force the defaults to be reinitialised. I've not yet worked out how to do that, but I'd say it's a 'bug'.