Manage Macros

Feedback and bug reports for Audacity 3.0.3 alpha
Forum rules
This forum is only for feedback and bug reports for the specified version of Audacity.

All bug reports must include the following information:
  • Exact version number of Audacity
  • Operating system version
  • Brief description of the problem
  • Detailed, step by step instructions for how to reproduce the problem
Bug reports that do not include the above information will be deleted

Additional information and / or screenshots should be included as necessary to adequately describe the problem.
steve
Site Admin
Posts: 81257
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Manage Macros

Post by steve » Mon Mar 15, 2021 5:17 pm

My suggestion:

Add a "Save" button in the left column. When pressed, any changes are saved and you will not be nagged to save changes.

Change the "Cancel" button to "Close". If there are unsaved changes you will be prompted to save changes before the dialog closes.

ManageMacro.png
ManageMacro.png (68.37 KiB) Viewed 480 times
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

waxcylinder
Forum Staff
Posts: 14663
Joined: Tue Jul 31, 2007 11:03 am
Operating System: Windows 10

Re: Manage Macros

Post by waxcylinder » Mon Mar 15, 2021 5:20 pm

steve wrote:
Mon Mar 15, 2021 5:17 pm
My suggestion:

Add a "Save" button in the left column. When pressed, any changes are saved and you will not be nagged to save changes.
It would surely be better on the right as you are Saving the editing that you are doing on that current focused Macro - the Save is the final part of the editing.
ManageMacro.png
ManageMacro.png (72.51 KiB) Viewed 479 times

steve wrote:
Mon Mar 15, 2021 5:17 pm
Change the "Cancel" button to "Close". If there are unsaved changes you will be prompted to save changes before the dialog closes.
Sounds sensible - since, as you say, Cancel doe not do "what it says on the tin"

Peter.
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * FAQ * * * * * Tutorials * * * * * Audacity Manual * * * * *

steve
Site Admin
Posts: 81257
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Manage Macros

Post by steve » Mon Mar 15, 2021 5:32 pm

waxcylinder wrote:
Mon Mar 15, 2021 5:20 pm
It would surely be better on the right as you are Saving the editing that you are doing on that current focused Macro - the Save is the final part of the editing.
I considered that, and there's more space for it on that side, but looking at the buttons in the left column and what they do:
  • New => make a new macro
  • Remove => remove / delete the selected macro
  • Rename => rename the selected macro
  • Restore => restore (back to default) the selected macro
  • Import => import a macro
  • Export => export the selected macro
  • Save => save changes to the selected macro
If there have been no changes, the "Save" button would be greyed out.

The left column are all about "macros", whereas the right column are about "commands". It is the selected macro that is being saved, not the selected command.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

waxcylinder
Forum Staff
Posts: 14663
Joined: Tue Jul 31, 2007 11:03 am
Operating System: Windows 10

Re: Manage Macros

Post by waxcylinder » Mon Mar 15, 2021 5:37 pm

I suspect this will be a case of our Audacity Mantra "Doer decides" ;)

And I suspect that is likely to be James as "Mr. Macros" :ugeek:

Peter.
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * FAQ * * * * * Tutorials * * * * * Audacity Manual * * * * *

FL Coast
Posts: 42
Joined: Wed Nov 29, 2017 7:07 pm
Operating System: Windows 10

Re: Manage Macros

Post by FL Coast » Mon Mar 15, 2021 5:40 pm

waxcylinder wrote:
Mon Mar 15, 2021 5:20 pm
steve wrote:
Mon Mar 15, 2021 5:17 pm
My suggestion:

Add a "Save" button in the left column. When pressed, any changes are saved and you will not be nagged to save changes.
It would surely be better on the right as you are Saving the editing that you are doing on that current focused Macro - the Save is the final part of the editing.
ManageMacro.png


steve wrote:
Mon Mar 15, 2021 5:17 pm
Change the "Cancel" button to "Close". If there are unsaved changes you will be prompted to save changes before the dialog closes.
Sounds sensible - since, as you say, Cancel doe not do "what it says on the tin"

Peter.
That makes more sense to me too.

billw58
Forum Staff
Posts: 5589
Joined: Wed Aug 12, 2009 2:10 am
Operating System: macOS 10.15 Catalina or later

Re: Manage Macros

Post by billw58 » Mon Mar 15, 2021 6:40 pm

steve wrote:
Mon Mar 15, 2021 5:32 pm
The left column are all about "macros", whereas the right column are about "commands". It is the selected macro that is being saved, not the selected command.
That may be technically correct, but to the user it looks like they are editing a macro by adding / removing / changing commands.

Thus I'd put the Save and Cancel buttons under the "Edit Steps" box.

-- Bill

steve
Site Admin
Posts: 81257
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Manage Macros

Post by steve » Mon Mar 15, 2021 6:48 pm

waxcylinder wrote:
Mon Mar 15, 2021 5:20 pm
It would surely be better on the right
Whether left or right column (I could live with either), I think adding a "Save" button and renaming "Cancel" as "Close" would be a big improvement.
If we're all in agreement, I'll add this as a proposed solution in the bug tracker.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

mafg1953
Posts: 199
Joined: Tue Nov 05, 2019 3:49 pm
Operating System: Windows 10

Re: Manage Macros

Post by mafg1953 » Mon Mar 15, 2021 8:50 pm

steve wrote:
Mon Mar 15, 2021 6:48 pm
If we're all in agreement, I'll add this as a proposed solution in the bug tracker.
Thanks - even though it didn't affect the macros themselves, this will be a welcome change.

waxcylinder
Forum Staff
Posts: 14663
Joined: Tue Jul 31, 2007 11:03 am
Operating System: Windows 10

Re: Manage Macros

Post by waxcylinder » Tue Mar 23, 2021 2:42 pm

This has been fixed for the upcoming 3.0.1 release.

1) The Cancel Button is replace with a Close button

2) The Close button does what you would expect it to

3) A new save button has been added to enable you to Save edits to a Macro

Manage_Macros_3-0-1png.png
Manage_Macros_3-0-1png.png (25.23 KiB) Viewed 402 times

I think this now looks, and works, a lot better.

Peter
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * FAQ * * * * * Tutorials * * * * * Audacity Manual * * * * *

mafg1953
Posts: 199
Joined: Tue Nov 05, 2019 3:49 pm
Operating System: Windows 10

Re: Manage Macros

Post by mafg1953 » Tue Mar 23, 2021 3:45 pm

waxcylinder wrote:
Tue Mar 23, 2021 2:42 pm
This has been fixed for the upcoming 3.0.1 release.
1) The Cancel Button is replace with a Close button
2) The Close button does what you would expect it to
3) A new save button has been added to enable you to Save edits to a Macro
I think this now looks, and works, a lot better.
Peter

Cool - thanks! So when your profile says you're retired, I'm assuming that doesn't refer to this audio stuff - you seem pretty full time to me!

Mike

Post Reply