Page 4 of 5
Re: Auto labelling - possible?
Posted: Mon Dec 08, 2014 1:25 am
by steve
It'll probably need some tidying by someone that knows how to program properly, but this patch works OK on Linux:
This needs to be applied to the source code, and then Audacity built from the modified source code. It adds a menu item to the Tracks menu: "Add Numbered Label".
The menu item may have a keyboard shortcut allocated. It may be used when playing or stopped.
Re: Auto labelling - possible?
Posted: Mon Dec 08, 2014 3:40 pm
by Gale Andrews
steve wrote:Gale Andrews wrote:If there is no playback, does your new key do nothing, or does it add an autolabel at the selection? Doing nothing does not seem very useful. If the new key autolabelled the selection when there was no playback, it could be a reasonable alternative to the "toggle" idea.
Certainly "we could just add" a behaviour for when playback is stopped.[...] We could "just add" anything anyone wants, but if we do, will this enhancement ever see the light of day?
Surely whether the same shortcut only adds a label at the playback position or also at the selection when not playing is just a design decision. That's not about adding exotic options for the labelling. We don't have to confine ourselves to the original suggestion.
Edit I see now in your patch that we can use this new shortcut when stopped, so thanks for that. That still makes more sense to me than doing nothing when stopped.
Gale
Re: Auto labelling - possible?
Posted: Tue Dec 09, 2014 11:56 am
by steve
Gale Andrews wrote:Edit I see now in your patch that we can use this new shortcut when stopped, so thanks for that. That still makes more sense to me than doing nothing when stopped.
As you said, just a design decision

Re: Auto labelling - possible?
Posted: Tue Dec 09, 2014 2:24 pm
by Gale Andrews
Can you make a normal unified diff patch against a standard tree? TortoiseSVN won't use what you posted and I guess it will save testers' time if it is a standard patch.
Gale
Re: Auto labelling - possible?
Posted: Tue Dec 09, 2014 3:39 pm
by steve
Here's a patch against revision 13730.
Re: Auto labelling - possible?
Posted: Tue Dec 09, 2014 10:47 pm
by Gale Andrews
steve wrote:Here's a patch against revision 13730.
Thanks for that, Steve.
It built OK on Windows and I tested it there. I am not going to test it anywhere else unless we agree to put it on Bugzilla.
Small point - there is no access key yet (and - bug in current code - Mix and Render to New Track does not have one). Perhaps "&w" for "Mix and Render to New Track" and "&b" for "Add Numbered Label"?
So this seems to be a straight count of numbered labels per project - no sort and rename if you add a numbered label to left of the last one you added. So what do you think about a new item for the Label Track dropdown menu to sort numbered labels (or to sort all labels)?
If this gets proposed for 2.1.1, I would still support customisation of the numbered labels (even if they would then be "autolabels" not numbered).
I would also like an option to reset the count when the last label track in the project is deleted. Or... reset the count when desired from the Label Track dropdown menu.
Gale
Re: Auto labelling - possible?
Posted: Tue Dec 09, 2014 11:12 pm
by steve
Gale Andrews wrote:if you add a numbered label to left of the last one you added. So what do you think about a new item for the Label Track dropdown menu to sort numbered labels (or to sort all labels)?
If this gets proposed for 2.1.1, I would still support customisation of the numbered labels (even if they would then be "autolabels" not numbered).
I would also like an option to reset the count when the last label track in the project is deleted. Or... reset the count when desired from the Label Track dropdown menu.
I can imagine that could involve months or even years of discussion. I'm more interested in seeing useful features released, and then building on that.
Re: Auto labelling - possible?
Posted: Wed Dec 10, 2014 12:41 pm
by Gale Andrews
steve wrote:Gale Andrews wrote:if you add a numbered label to left of the last one you added. So what do you think about a new item for the Label Track dropdown menu to sort numbered labels (or to sort all labels)?
If this gets proposed for 2.1.1, I would still support customisation of the numbered labels (even if they would then be "autolabels" not numbered).
I would also like an option to reset the count when the last label track in the project is deleted. Or... reset the count when desired from the Label Track dropdown menu.
I can imagine that could involve months or even years of discussion. I'm more interested in seeing useful features released, and then building on that.
If a count reset or a label sort needs "years of discussion" then the system is broken IMHO

.
Personally I think the reset is a reasonable suggestion that saves having to close the project.
I'll wait to hear from you about your choices of access keys.
Gale
Re: Auto labelling - possible?
Posted: Wed Dec 10, 2014 1:10 pm
by steve
Gale Andrews wrote:I'll wait to hear from you about your choices of access keys.
As you wrote, "b" is currently available, so that will be OK assuming no other changes to the Tracks menu.
As per your suggestion, I've added "w" for "Mix and render to new track" in revision 13734.
Re: Auto labelling - possible?
Posted: Wed Dec 10, 2014 1:19 pm
by steve
Gale Andrews wrote:If a count reset or a label sort needs "years of discussion" then the system is broken IMHO

.
"
Export to mono MP3: (17 votes)" has been under discussion for nearly 4 years
