Auto labelling - possible?

This read-only archive contains discussions from the Adding Feature forum.
New feature request may be posted to the Adding Feature forum.
Technical support is available via the Help forum.
steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Auto labelling - possible?

Post by steve » Mon Dec 08, 2014 1:25 am

It'll probably need some tidying by someone that knows how to program properly, but this patch works OK on Linux:
AutoNumLabels.patch
(6.46 KiB) Downloaded 44 times
This needs to be applied to the source code, and then Audacity built from the modified source code. It adds a menu item to the Tracks menu: "Add Numbered Label".
The menu item may have a keyboard shortcut allocated. It may be used when playing or stopped.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Gale Andrews
Quality Assurance
Posts: 41761
Joined: Fri Jul 27, 2007 12:02 am
Operating System: Windows 10

Re: Auto labelling - possible?

Post by Gale Andrews » Mon Dec 08, 2014 3:40 pm

steve wrote:
Gale Andrews wrote:If there is no playback, does your new key do nothing, or does it add an autolabel at the selection? Doing nothing does not seem very useful. If the new key autolabelled the selection when there was no playback, it could be a reasonable alternative to the "toggle" idea.
Certainly "we could just add" a behaviour for when playback is stopped.[...] We could "just add" anything anyone wants, but if we do, will this enhancement ever see the light of day?
Surely whether the same shortcut only adds a label at the playback position or also at the selection when not playing is just a design decision. That's not about adding exotic options for the labelling. We don't have to confine ourselves to the original suggestion.

Edit I see now in your patch that we can use this new shortcut when stopped, so thanks for that. That still makes more sense to me than doing nothing when stopped.


Gale
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * Tips * * * * * Tutorials * * * * * Quick Start Guide * * * * * Audacity Manual

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Auto labelling - possible?

Post by steve » Tue Dec 09, 2014 11:56 am

Gale Andrews wrote:Edit I see now in your patch that we can use this new shortcut when stopped, so thanks for that. That still makes more sense to me than doing nothing when stopped.
As you said, just a design decision ;)
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Gale Andrews
Quality Assurance
Posts: 41761
Joined: Fri Jul 27, 2007 12:02 am
Operating System: Windows 10

Re: Auto labelling - possible?

Post by Gale Andrews » Tue Dec 09, 2014 2:24 pm

Can you make a normal unified diff patch against a standard tree? TortoiseSVN won't use what you posted and I guess it will save testers' time if it is a standard patch.


Gale
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * Tips * * * * * Tutorials * * * * * Quick Start Guide * * * * * Audacity Manual

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Auto labelling - possible?

Post by steve » Tue Dec 09, 2014 3:39 pm

Here's a patch against revision 13730.
Attachments
AutoNumLabels.diff
(5.88 KiB) Downloaded 37 times
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Gale Andrews
Quality Assurance
Posts: 41761
Joined: Fri Jul 27, 2007 12:02 am
Operating System: Windows 10

Re: Auto labelling - possible?

Post by Gale Andrews » Tue Dec 09, 2014 10:47 pm

steve wrote:Here's a patch against revision 13730.
Thanks for that, Steve.

It built OK on Windows and I tested it there. I am not going to test it anywhere else unless we agree to put it on Bugzilla.

Small point - there is no access key yet (and - bug in current code - Mix and Render to New Track does not have one). Perhaps "&w" for "Mix and Render to New Track" and "&b" for "Add Numbered Label"?

So this seems to be a straight count of numbered labels per project - no sort and rename if you add a numbered label to left of the last one you added. So what do you think about a new item for the Label Track dropdown menu to sort numbered labels (or to sort all labels)?

If this gets proposed for 2.1.1, I would still support customisation of the numbered labels (even if they would then be "autolabels" not numbered).

I would also like an option to reset the count when the last label track in the project is deleted. Or... reset the count when desired from the Label Track dropdown menu.


Gale
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * Tips * * * * * Tutorials * * * * * Quick Start Guide * * * * * Audacity Manual

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Auto labelling - possible?

Post by steve » Tue Dec 09, 2014 11:12 pm

Gale Andrews wrote:if you add a numbered label to left of the last one you added. So what do you think about a new item for the Label Track dropdown menu to sort numbered labels (or to sort all labels)?

If this gets proposed for 2.1.1, I would still support customisation of the numbered labels (even if they would then be "autolabels" not numbered).

I would also like an option to reset the count when the last label track in the project is deleted. Or... reset the count when desired from the Label Track dropdown menu.
I can imagine that could involve months or even years of discussion. I'm more interested in seeing useful features released, and then building on that.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Gale Andrews
Quality Assurance
Posts: 41761
Joined: Fri Jul 27, 2007 12:02 am
Operating System: Windows 10

Re: Auto labelling - possible?

Post by Gale Andrews » Wed Dec 10, 2014 12:41 pm

steve wrote:
Gale Andrews wrote:if you add a numbered label to left of the last one you added. So what do you think about a new item for the Label Track dropdown menu to sort numbered labels (or to sort all labels)?

If this gets proposed for 2.1.1, I would still support customisation of the numbered labels (even if they would then be "autolabels" not numbered).

I would also like an option to reset the count when the last label track in the project is deleted. Or... reset the count when desired from the Label Track dropdown menu.
I can imagine that could involve months or even years of discussion. I'm more interested in seeing useful features released, and then building on that.
If a count reset or a label sort needs "years of discussion" then the system is broken IMHO ;) .

Personally I think the reset is a reasonable suggestion that saves having to close the project.

I'll wait to hear from you about your choices of access keys.


Gale
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * Tips * * * * * Tutorials * * * * * Quick Start Guide * * * * * Audacity Manual

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Auto labelling - possible?

Post by steve » Wed Dec 10, 2014 1:10 pm

Gale Andrews wrote:I'll wait to hear from you about your choices of access keys.
As you wrote, "b" is currently available, so that will be OK assuming no other changes to the Tracks menu.
As per your suggestion, I've added "w" for "Mix and render to new track" in revision 13734.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: Auto labelling - possible?

Post by steve » Wed Dec 10, 2014 1:19 pm

Gale Andrews wrote:If a count reset or a label sort needs "years of discussion" then the system is broken IMHO ;) .
"Export to mono MP3: (17 votes)" has been under discussion for nearly 4 years ;)
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Locked