Error on sliding time scale/pitch shift - SOLVED

[mdubin]

Thanks. We've already declared the code freeze for the upcoming 2.0.2 release, so Clayton's fix probably won't get into 2.0.2 unless we make more changes to the code for other reasons. But if you let us know within 36 hours or so it might increase the chances the fix would go into 2.0.2. The "audacity_bug_557.exe" is otherwise very similar to the code planned for release in 2.0.2.


Gale

Gale:

I'll do some more testing this evening and post here as soon as I have finished.

mdubin

[mdubin]

Gale:

I did one more test and it did not crash.

BUT there is a much bigger problem now which was definitely not there before and was certainly not in the source WAV file.

I decided to play back one of the processed tracks and I heard a lot of distortion. So in fixing the "crash" problem, it appears that another one was created.

Here is the link to one of them

http://www.sendspace.com/file/1cqrdd

I guess I will have to go with Song Surgeon even though it is not free.

mdubin

[Gale Andrews]

You are sure Sliding Time Scale did that - Edit > Undo TIme Scale cured it?

Was there anything different about the file characteristics or source of that WAV?

If there is a chance you could repeat the problem then (depending what Clayton thinks) we could try Clayton's current fix but going back to memcpy.


Gale

[mdubin]

You are sure Sliding Time Scale did that - Edit > Undo TIme Scale cured it?

Was there anything different about the file characteristics or source of that WAV?

If there is a chance you could repeat the problem then (depending what Clayton thinks) we could try Clayton's current fix but going back to memcpy.


Gale

Gale:

Yes, Sliding Time Scale did it. I checked the eight other processed files and all of them exhibited the same "noise" as the one I posted here. I did not do the "undo" because I did not become aware of this "distortion or "noise" problem until afterwards. However, I did check the nine source files and they were perfectly fine. There is nothing different about these Wav files. All of them were ripped from CDs using the same ripping software that I have been using for a couple of years and, like I said, exhibited no audio problems.

I do not know what else to say. Your staff has been extremely helpful in trying to resolve the "crash" issue. Too bad that another serious problem resulted from trying to fix it.

Let me know if there is anything else I can do.

mdubin

[Gale Andrews]

I agree the sound quality is useless in Clayton's latest fix (in "audacity_bug_557.exe") - I tested this on both Windows 7 32-bit and Windows 7 64-bit. Thanks for finding that. I too have no stability issues with that .exe in 32-bit or 64-bit Windows.

On Windows 7 32-bit and XP 32-bit (but not Win 7 64-bit) I get repeatable crashes with Sliding Time Scale in the 2.0.2 release candidate (rc). I do not get those crashes on the 32-bit systems in the 2.0.1 release, so I am assuming at the moment that Clayton's committed fix for the crashes (which are in the 2.0.2 rc and which had no fixative effect for mdubin) have made things far worse for my 32-bit systems.

This is very confused, but I did make a build that retained the fix as per "audacity_bug_557.exe" but undid the change from memcpy to memmove which was applied to fix quality problems on Linux 64-bit. This change does nothing for the quality problems in Windows 32-bit or 64-bit, so I can only assume at the moment that Clayton's latest fix does directly affect the quality.

So no solutions at the moment - I'll have to discuss the crashing with the developers now that I am seeing it repeatedly on 32-bit.



Gale

[mdubin]

Gale:

Thanks.

I'll continue to use Audacity for everything BUT sliding time scale/pitch shift.

mdubin

[Gale Andrews]

I'll continue to use Audacity for everything BUT sliding time scale/pitch shift.

Although it is more hassle you could perhaps keep the 2.0.0 audacity.exe (suitably renamed) in the 2.0.1 folder, quit 2.0.1 and run 2.0.0 from the 2.0.1 folder just to do Time Scale. The zip of 2.0.0 is here:
http://audacity.googlecode.com/files/au ... in-2.0.zip .

Or just use 2.0.0 for now.

Note that in 2.0.0, Time Scale could make an audible discontinuity at the start of the selection.



Gale

[mdubin]

Gale:

Thanks for the suggestion.

mdubin

[Gale Andrews]

Clayton has made a completely fresh patch which on a cursory test on my Win 32-bit systems doesn't crash and doesn't have sound quality issues. That build is "audacity_bug_557p3.exe" in http://gaclrecords.org.uk/bugs/audacity ... 2aug12.zip .

I also included in that zip "audacity_bug_557_revert_11858p1.exe". That build simply reverts part of Clayton's first attempt at a fix which caused crashes for me. That build also doesn't crash or have quality issues on my 32-bit systems. If anything however the sound quality in "audacity_bug_557p3.exe" seems better to me - more "rounded" and less "hard".

If you have time I would suggest trying two or three runs with each .exe. Thanks for your patience with this.


Gale

[mdubin]

Clayton has made a completely fresh patch which on a cursory test on my Win 32-bit systems doesn't crash and doesn't have sound quality issues. That build is "audacity_bug_557p3.exe" in http://gaclrecords.org.uk/bugs/audacity ... 2aug12.zip .

I also included in that zip "audacity_bug_557_revert_11858p1.exe". That build simply reverts part of Clayton's first attempt at a fix which caused crashes for me. That build also doesn't crash or have quality issues on my 32-bit systems. If anything however the sound quality in "audacity_bug_557p3.exe" seems better to me - more "rounded" and less "hard".

If you have time I would suggest trying two or three runs with each .exe. Thanks for your patience with this.


Gale

Gale:

Just did two tests with bug_557p3. The first one was successful with no quality issues. But the 2nd one crashed, and this time, it was not at the end but shortly after starting the process.

mdubin