For questions, answers and opinions
https://forum.audacityteam.org/
+1 from me to thatsteve wrote:I agree that it would be better if the user setting was retained, (and for safety, the default set to unchecked, don't overwrite).
+1 but I don't want to default to off unless the user's setting is retained. I think most users want to overwrite.waxcylinder wrote:+1 from me to thatsteve wrote:I agree that it would be better if the user setting was retained, (and for safety, the default set to unchecked, don't overwrite).
@Steve: do you have the skills to "make it so"
Peter
It's a very simple change; currently (before the change to wxWidgets 3) the code looks like (in \src\export\ExportMultiple.cpp at or near line number 352):waxcylinder wrote:@Steve: do you have the skills to "make it so"
Code: Select all
S.StartHorizontalLay(wxEXPAND, false);
{
mOverwrite = S.Id(OverwriteID).AddCheckBox(_("Overwrite existing files"), wxT("true"));
}
S.EndHorizontalLay();
Code: Select all
S.StartHorizontalLay(wxEXPAND, false);
{
wxString overwriteExisting(wxT("true"));
gPrefs->Read(wxT("/Export/OverwriteExisting"), &overwriteExisting, wxT("true"));
mOverwrite = S.Id(OverwriteID).TieCheckBox(_("Overwrite existing files"), overwriteExisting, wxT("true"));
}
S.EndHorizontalLay();
How about just:Edgar wrote:It's a very simple change; currently (before the change to wxWidgets 3) the code looks like (in \src\export\ExportMultiple.cpp at or near line number 352):waxcylinder wrote:@Steve: do you have the skills to "make it so"needs two additional statements:Code: Select all
S.StartHorizontalLay(wxEXPAND, false); { mOverwrite = S.Id(OverwriteID).AddCheckBox(_("Overwrite existing files"), wxT("true")); } S.EndHorizontalLay();and the changeover from a generic wxWidgets checkbox to a Preferences-aware TieCheckBox.Code: Select all
S.StartHorizontalLay(wxEXPAND, false); { wxString overwriteExisting(wxT("true")); gPrefs->Read(wxT("/Export/OverwriteExisting"), &overwriteExisting, wxT("true")); mOverwrite = S.Id(OverwriteID).TieCheckBox(_("Overwrite existing files"), overwriteExisting, wxT("true")); } S.EndHorizontalLay();
Code: Select all
{
mOverwrite = S.Id(OverwriteID).TieCheckBox(_("Overwrite existing files"),
wxT("/Export/OverwriteExisting"),
true);
}
I tried that first and got a compiler warning (maybe because "true" can be defined as a BOOL or as an INT depending on the OS and/or compiler). If you search the code for other instances where we use a TieCheckBox you will see that, historically, it is done the way I did it. FYI your way does not work on my system (Windows 7, MSVS 2010 & 2013, WxWidgets 2.8 - next week I should be on Windows 10, MSVS 2015 & wxWidgets 3.0).steve wrote: How about just:Code: Select all
{ mOverwrite = S.Id(OverwriteID).TieCheckBox(_("Overwrite existing files"), wxT("/Export/OverwriteExisting"), true); }