expand on Norm's new track name in display

Audio software developers forum.
Forum rules
If you require help using Audacity, please post on the forum board relevant to your operating system:
Windows
Mac OS X
GNU/Linux and Unix-like
steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: expand on Norm's new track name in display

Post by steve » Sun Jan 29, 2012 11:34 am

Edgar wrote:The color picker is build in to the font picker dialog
Where?
prefs.png
prefs.png (92.62 KiB) Viewed 3148 times
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Edgar
Forum Crew
Posts: 2043
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 10

Re: expand on Norm's new track name in display

Post by Edgar » Sun Jan 29, 2012 5:58 pm

steve wrote:
Edgar wrote:The color picker is build in to the font picker dialog
Where?
Sorry I guess that is a feature missing on the wxGTK version. Look at the image in this reply:
http://forum.audacityteam.org/search.ph ... etermined.
about half way down page 2 of this thread. I would be fairly easy to add a color picker back to the Prefs panel (contingent on wxGTK)--I'll look at it today.
-Edgar
running Audacity personally customized 2.0.6 daily in a professional audio studio
occasionally using current Audacity alpha for testing and support situations
64-bit Windows Pro 10

Edgar
Forum Crew
Posts: 2043
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 10

Re: expand on Norm's new track name in display

Post by Edgar » Sun Jan 29, 2012 7:23 pm

OK, back to ugly (at least on Linux); I stuck in a color picker, but, again, as ShuttleGUI does not do color pickers I had to roll-my-own. My Linux install is not playing nice with wxWidgets & Audacity and I forget how to run Audacity under a debugger--I know I did it once last year using Ubuntu.

Give patch 8 a try on Linux (there is no difference between 7 & 8 except on Linux). If it works for you I will see if I can refresh the color on the font dialog button dynamically after the color picker is dismissed.
Attachments
sizeColorFamilyViaFontDialogAndGTKcolor8.patch
(7.03 KiB) Downloaded 105 times
-Edgar
running Audacity personally customized 2.0.6 daily in a professional audio studio
occasionally using current Audacity alpha for testing and support situations
64-bit Windows Pro 10

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: expand on Norm's new track name in display

Post by steve » Sun Jan 29, 2012 8:54 pm

Audacity builds with sizeColorFamilyViaFontDialogAndGTKcolor8.patch but it seg faults when trying to open Preferences.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: expand on Norm's new track name in display

Post by steve » Sun Jan 29, 2012 9:13 pm

Scrap the last comment, my mistake. Rebuilt and it's not seg faulting this time. I think that I forgot to revert a previous patch.
It builds OK now and Preferences opens, but there's still problems.
Details to follow....
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: expand on Norm's new track name in display

Post by steve » Sun Jan 29, 2012 10:11 pm

Code: Select all

make distclean
./configure
make
No problems so far.

Launch Audacity
Open Preferences.
Colour Chooser and System Font dialogue are present.
Colour chooser and System Font dialogue can both be opened, but the text in the System Font dialogue button does not change.
Click "OK" or "Cancel" to close Preferences.
Edit menu > Preferences
Segmentation fault.

Launch Audacity
Open Preferences.
Set the font and the colour
Exit Audacity.
Launch Audacity
Open Preferences.
The system Font dialogue button shows the correct font and colour.
Add a new track. The writing uses the correct font but the colour is black (regardless of selected colour).
Delete track.
Open Preferences.
The system Font dialogue button still shows the correct font and colour.
Close Preferences.
Add a new track. The writing uses the correct font but the colour is black (regardless of selected colour).
Edit menu > Preferences
Segmentation fault.



Launch Audacity
Open Preferences.
Add a new track. The writing uses the correct font but the colour is black (regardless of selected colour).
Edit menu > Preferences
Segmentation fault.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Edgar
Forum Crew
Posts: 2043
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 10

Re: expand on Norm's new track name in display

Post by Edgar » Mon Jan 30, 2012 12:28 am

Maybe the reason there is no color picker in the Linux font dialog is that wxWidgets does not do color fonts with Linux. I am seeing similar segfault behavior here but it is random. I installed Ubuntu 10.10 64-bit but could not get Audacity to compile (myself and others have had this problem since last May).

For now I guess we must drop color support on Linux, fall back to the previous patch and hope that someone can test on Mac.

Maybe some Linux guru could be enticed into doing some work on this--I have no pull with anyone like that. Maybe Benjamin Drung would look at it but I have no way to contact him.
-Edgar
running Audacity personally customized 2.0.6 daily in a professional audio studio
occasionally using current Audacity alpha for testing and support situations
64-bit Windows Pro 10

steve
Site Admin
Posts: 81609
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu

Re: expand on Norm's new track name in display

Post by steve » Mon Jan 30, 2012 6:08 pm

Edgar wrote:Maybe the reason there is no color picker in the Linux font dialog is that wxWidgets does not do color fonts with Linux.
But it works OK with the color picker with the Wx fonts? Strange.
Edgar wrote:I installed Ubuntu 10.10 64-bit but could not get Audacity to compile (myself and others have had this problem since last May).
Is that perhaps the FFmpeg problem? I think that should be fixed now.
Svn should build on Ubuntu - the last "Daily Build" was 31 hours ago: https://launchpad.net/~audacity-team/+archive/daily

Did we have font size + color working in one of the patches? I think that would be a more useful combination for Linux than system fonts and no color choice.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Edgar
Forum Crew
Posts: 2043
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 10

Re: expand on Norm's new track name in display

Post by Edgar » Mon Jan 30, 2012 11:11 pm

steve wrote:
Edgar wrote:Maybe the reason there is no color picker in the Linux font dialog is that wxWidgets does not do color fonts with Linux.
But it works OK with the color picker with the Wx fonts? Strange.
My original solution was a bit of a hack (but it worked for colorized fonts in this case)!
steve wrote:[
Edgar wrote:I installed Ubuntu 10.10 64-bit but could not get Audacity to compile (myself and others have had this problem since last May).
Is that perhaps the FFmpeg problem? I think that should be fixed now.
Svn should build on Ubuntu
This time it was some conflict with vorbis. I did get it to compile (but not really run) on Debian Squeeze.

steve wrote: Did we have font size + color working in one of the patches? I think that would be a more useful combination for Linux than system fonts and no color choice.
Yes, but font color via a color picker was a hack that would never pass QA. Since the color picker control is not part of ShuttleGUI the precise location of the color picker is indeterminable based on the ShuttleGUI layout.

Font size is doable as it uses a ShuttleGUI control. The code using three integer fields (available via ShuttleGUI) to specify color would also work but would not pass my "smell" test.

The button-to-open-a-font-picker could pass QA as it is ShuttleGUI-compliant but as it denies color to Linux (and who knows what happens on Mac) also has serious limitations.

Bare minimum would be a size Pref only--easy and no QA drawbacks. As 2.0 freeze is only days away I do not see any solution passing QA and Developers in time for inclusion without a real push to lobby Martyn (who reviewed & committed Norm's code with little or no QA input). Other than Bill's one approval post Steve and I are the only ones posting anything to this thread--maybe Gale can comment...
-Edgar
running Audacity personally customized 2.0.6 daily in a professional audio studio
occasionally using current Audacity alpha for testing and support situations
64-bit Windows Pro 10

Edgar
Forum Crew
Posts: 2043
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 10

Re: expand on Norm's new track name in display

Post by Edgar » Fri Feb 03, 2012 7:15 pm

After re-thinking the whole user experience and taking the known limitation of wxGTK (Linux--no color picker in the font dialog) and potential unknowns on Mac I came up with a new software algorithm and GUI. Here is the new look:
fontColorAndSize9.png
fontColorAndSize9.png (38.75 KiB) Viewed 3114 times
In an effort to conserve space I added a new section within the "Behaviors" section to encompass all the "name in wavetrack" behaviors. This allows me to shorten the button names so they will fix on one line even with 30+ size fonts. I tried putting them on two lines but the max height of the Prefs dialog restricts this to ~22 size fonts. The built-in MSW color-picker-in-font-dialog still works and the button works for it too--I thought of leaving the color button off for MSW but thought it would cause confusion and problems for the manual.

Here is the default look:
fontColorAndSize9Win7basic.png
fontColorAndSize9Win7basic.png (22.66 KiB) Viewed 3114 times
Attachments
sizeColorFamilyViaFontDialogAndGTKcolor9.patch
(8.02 KiB) Downloaded 93 times
-Edgar
running Audacity personally customized 2.0.6 daily in a professional audio studio
occasionally using current Audacity alpha for testing and support situations
64-bit Windows Pro 10

Post Reply