Squelch some warnings

Building and customizing Audacity from the source code.
Forum rules
If you require help using Audacity, please post on the forum board relevant to your operating system:
Windows
Mac OS X
GNU/Linux and Unix-like
Post Reply
Edgar
Forum Crew
Posts: 1516
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 7
Contact:

Squelch some warnings

Post by Edgar » Tue Nov 11, 2014 3:05 am

Patch attached

Code: Select all

Not done, a bit tricky: srcfileio.cpp(100): warning C4100: 'type' : unreferenced formal parameter
srcimagemanipulation.cpp(277): warning C4100: 'offset' : unreferenced formal parameter
srcmenus.cpp(937): warning C4189: 'pm' : local variable is initialized but not referenced
srcmenus.cpp(938): warning C4101: 'plug' : unreferenced local variable
srcmenus.cpp(295): warning C4101: 'effects' : unreferenced local variable
srcmenus.cpp(1008): warning C4189: 'additionalEffects' : local variable is initialized but not referenced
srcmenus.cpp(294): warning C4189: 'em' : local variable is initialized but not referenced
srcmenus.cpp(1435): warning C4018: '>' : signed/unsigned mismatch
srcmenus.cpp(1445): warning C4018: '>' : signed/unsigned mismatch
srcmenus.cpp(1356): warning C4189: 'f' : local variable is initialized but not referenced
srcpluginmanager.cpp(1758): warning C4100: 'type' : unreferenced formal parameter
Not done, questionable: srceffectseffectmanager.cpp(667): warning C4172: returning address of local variable or temporary
Not done, questionable: srceffectseffectmanager.cpp(681): warning C4172: returning address of local variable or temporary
srceffectsladspaladspaeffect.cpp(684): warning C4100: 'maxBlockSize' : unreferenced formal parameter
srcprefseffectsprefs.cpp(162): warning C4800: 'long' : forcing value to bool 'true' or 'false' (performance warning)
srcprefseffectsprefs.cpp(159): warning C4100: 'key' : unreferenced formal parameter
srcprefslibraryprefs.cpp(132): warning C4189: 'bfnd' : local variable is initialized but not referenced
srcprefslibraryprefs.cpp(138): warning C4189: 'bdwn' : local variable is initialized but not referenced
srctoolbarscontroltoolbar.cpp(629): warning C4100: 'p' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'row' : unreferenced formal parameter
srcwidgetsgrid.cpp(327): warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp(326): warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp(325): warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp(325): warning C4100: 'row' : unreferenced formal parameter
srcwidgetsnumerictextctrl.cpp(1690): warning C4100: 'digit' : unreferenced formal parameter
Attachments
warnings.patch
(11.91 KiB) Downloaded 97 times
-Edgar
compiling Audacity daily
64-bit Windows 7

Edgar
Forum Crew
Posts: 1516
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 7
Contact:

Re: Squelch some warnings

Post by Edgar » Mon Nov 24, 2014 4:57 pm

bump…

Freeze fast approaching; warnings in src/ (as opposed to lib-src/) are considered as unacceptable; the patch is probably stale but all the fixes are easy to apply by hand; of the five downloaders of the patch, does anyone have a comment?
-Edgar
compiling Audacity daily
64-bit Windows 7

steve
Site Admin
Posts: 47249
Joined: Sat Dec 01, 2007 11:43 am
Operating System: Linux *buntu
Contact:

Re: Squelch some warnings

Post by steve » Mon Nov 24, 2014 6:14 pm

I've only checked the changes that you proposed for src/Menus.cpp, and none of the code that you have changed exists in current svn.
9/10 questions are answered in the FREQUENTLY ASKED QUESTIONS (FAQ)

Edgar
Forum Crew
Posts: 1516
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 7
Contact:

Re: Squelch some warnings

Post by Edgar » Mon Nov 24, 2014 7:54 pm

steve wrote:I've only checked the changes that you proposed for src/Menus.cpp, and none of the code that you have changed exists in current svn.
Great, nothing worse than a stale patch <grin>! No time this morning to investigate further…
-Edgar
compiling Audacity daily
64-bit Windows 7

Edgar
Forum Crew
Posts: 1516
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 7
Contact:

Re: Squelch some warnings

Post by Edgar » Mon Nov 24, 2014 11:35 pm

Upon further investigation, with SVN HEAD 13643:

Code: Select all

srcfileio.cpp(100): warning C4100: 'type' : unreferenced formal parameter
srcimagemanipulation.cpp(277): warning C4100: 'offset' : unreferenced formal parameter
srcmodulemanager.cpp(590): warning C4100: 'providerID' : unreferenced formal parameter
srcpluginmanager.cpp(1714): warning C4100: 'forceRescan' : unreferenced formal parameter
srcnotetrack.cpp(217): warning C4706: assignment within conditional expression
srcwidgetsnumerictextctrl.cpp(1690): warning C4100: 'digit' : unreferenced formal parameter
srceffectsvstvsteffect.cpp(554): warning C4100: 'ID' : unreferenced formal parameter
srceffectsvstvsteffect.cpp(2013): warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)
srcprefslibraryprefs.cpp(132): warning C4189: 'bfnd' : local variable is initialized but not referenced
srcprefslibraryprefs.cpp(138): warning C4189: 'bdwn' : local variable is initialized but not referenced
srcimportimportmidi.cpp(72): warning C4706: assignment within conditional expression
srcwidgetsgrid.cpp(93): warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp(93): warning C4100: 'row' : unreferenced formal parameter
srcwidgetsgrid.cpp(327): warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp(326): warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp(325): warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp(325): warning C4100: 'row' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp(142): warning C4100: 'pm' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp(148): warning C4100: 'path' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp(148): warning C4100: 'pm' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp(166): warning C4100: 'path' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp(165): warning C4100: 'ID' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp(173): warning C4100: 'instance' : unreferenced formal parameter
srceffectsladspaladspaeffect.cpp(349): warning C4100: 'ID' : unreferenced formal parameter
srceffectsladspaladspaeffect.cpp(784): warning C4100: 'maxBlockSize' : unreferenced formal parameter
srctoolbarscontroltoolbar.cpp(629): warning C4100: 'p' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(114): warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(209): warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(215): warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(215): warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(222): warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(237): warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(236): warning C4100: 'ID' : unreferenced formal parameter
srceffectsvamploadvamp.cpp(244): warning C4100: 'instance' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(258): warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(308): warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(314): warning C4100: 'path' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(314): warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(320): warning C4100: 'ID' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(331): warning C4100: 'path' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(330): warning C4100: 'ID' : unreferenced formal parameter
srceffectslv2loadlv2.cpp(338): warning C4100: 'instance' : unreferenced formal parameter
srceffectsnyquistNyquist.h(209): warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistNyquist.h(209): warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
-Edgar
compiling Audacity daily
64-bit Windows 7

Gale Andrews
Quality Assurance
Posts: 26087
Joined: Fri Jul 27, 2007 12:02 am
Operating System: Windows 10
Contact:

Re: Squelch some warnings

Post by Gale Andrews » Tue Nov 25, 2014 10:40 pm

Edgar wrote:Freeze fast approaching
It's a GUI/strings freeze, I believe...

Gale
________________________________________FOR INSTANT HELP: (Click on Link below)
* * * * * Tips * * * * * Tutorials * * * * * Quick Start Guide * * * * * Audacity Manual

Edgar
Forum Crew
Posts: 1516
Joined: Thu Sep 03, 2009 9:13 pm
Operating System: Windows 7
Contact:

Re: Squelch some warnings

Post by Edgar » Sat Nov 29, 2014 10:45 pm

Most of these are covered in the previously attached patch…
SVN HEAD 13665:

Code: Select all

Link warnings		
winProjectsAudacityAboutDialog.obj	Audacity	warning LNK4075: ignoring '/EDITANDCONTINUE' due to '/SAFESEH' specification
winProjectsAudacityAboutDialog.obj	Audacity	warning LNK4075: ignoring '/EDITANDCONTINUE' due to '/SAFESEH' specification
winProjectssoundtouchmmx_optimized.obj	soundtouch	warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
winProjectssoundtouchmmx_optimized.obj	soundtouch	warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library

Code: Select all

File	Line #	Warning
srcaudioio.cpp	3590	warning C4701: potentially uninitialized local variable 'selected' used
srceffectsladspaladspaeffect.cpp	349	warning C4100: 'ID' : unreferenced formal parameter
srceffectsladspaladspaeffect.cpp	784	warning C4100: 'maxBlockSize' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	258	warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	308	warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	314	warning C4100: 'path' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	314	warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	320	warning C4100: 'ID' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	330	warning C4100: 'ID' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	331	warning C4100: 'path' : unreferenced formal parameter
srceffectslv2loadlv2.cpp	338	warning C4100: 'instance' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp	142	warning C4100: 'pm' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp	148	warning C4100: 'path' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp	165	warning C4100: 'ID' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp	166	warning C4100: 'path' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp	173	warning C4100: 'instance' : unreferenced formal parameter
srceffectsnyquistNyquist.h	209	warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistNyquist.h	209	warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistnyquist.h	209	warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistnyquist.h	209	warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsvamploadvamp.cpp	114	warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	209	warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	215	warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	215	warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	222	warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	236	warning C4100: 'ID' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	237	warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp	244	warning C4100: 'instance' : unreferenced formal parameter
srceffectsvstvsteffect.cpp	554	warning C4100: 'ID' : unreferenced formal parameter
srceffectsVSTVSTEffect.cpp	2013	warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)
srceffectsvstvsteffect.cpp	2013	warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)
srcfileio.cpp	100	warning C4100: 'type' : unreferenced formal parameter
srcimagemanipulation.cpp	277	warning C4100: 'offset' : unreferenced formal parameter
srcimportimportmidi.cpp	72	warning C4706: assignment within conditional expression
srcmodulemanager.cpp	590	warning C4100: 'providerID' : unreferenced formal parameter
srcnotetrack.cpp	217	warning C4706: assignment within conditional expression
srcpluginmanager.cpp	1719	warning C4100: 'forceRescan' : unreferenced formal parameter
srcprefslibraryprefs.cpp	132	warning C4189: 'bfnd' : local variable is initialized but not referenced
srcprefslibraryprefs.cpp	138	warning C4189: 'bdwn' : local variable is initialized but not referenced
srctoolbarscontroltoolbar.cpp	619	warning C4100: 'p' : unreferenced formal parameter
srctrackpanelax.cpp	440	warning C4100: 'strValue' : unreferenced formal parameter
srctrackpanelax.cpp	440	warning C4100: 'childId' : unreferenced formal parameter
srcwidgetsgrid.cpp	93	warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp	93	warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp	93	warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp	93	warning C4100: 'row' : unreferenced formal parameter
srcwidgetsgrid.cpp	325	warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp	325	warning C4100: 'row' : unreferenced formal parameter
srcwidgetsgrid.cpp	326	warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp	327	warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp	873	warning C4100: 'childId' : unreferenced formal parameter
-Edgar
compiling Audacity daily
64-bit Windows 7

Post Reply