Page 1 of 1

Potential compiler failure

Posted: Mon Sep 29, 2014 6:19 am
by Edgar
In the source file: srcexportExportFLAC.cpp at or near line number 240:

Code: Select all

#ifdef LEGACY_FLAC
   encoder.set_filename(OSOUTPUT(fName));
#endif
If LEGACY_FLAC somehow gets set, the above will fail to compile because the function:

Code: Select all

encoder.set_filename(…)
does not exist. Have a look at: lib-srclibflacincludeFLAC++encoder.h between lines 127 & 149 where all of the set… () functions are listed– it is not there.

Re: Potential compiler failure

Posted: Mon Sep 29, 2014 9:28 am
by steve
It looks to be very old cruft (circa 2006). If it is to be cleaned up, then there is also:
#if !defined FLACPP_API_VERSION_CURRENT || FLACPP_API_VERSION_CURRENT < 6
in a couple of places.
The version that we are currently using appears to be 9
(line 60 export.h)