Sorry if that last post appeared rather brusk, it was posted in a rush.
Having given it some consideration;
I think that for accuracy the name of the Q control should be “Q” or “Q factor” rather than “Width” but by including “(higher value reduces width)” the meaning is made clear for all.
I have reservations about the error message “Frequency must be at least 0 Hz.” because although it is accurate in as far as 0Hz does not produce an error, I feel that it implies that 0Hz is a reasonable value, when in practice it does nothing. Currently the user has to wait for the sound to be written back (unaltered) to the track, which could be a significant wait for a long track. I think it would be better if the user was informed straight away that the effect is doing nothing.
So the situation is:
- Negative frequencies are invalid and so should generate an error
- 0 Hz should not produce an error, but it should be clear that it does nothing.
What I propose is:
- For a negative frequency value the error message should be “ErrornNegative frequency is invalid.” (or something similar)
- 0 Hz should generate a “non-error” message of “Nothing to be done.” (or something similar).
Thanks for the feedback Gale, I’m in full agreement with the other changes that you’ve made.
(I’ve also added the expanded GPL license information in the comment as discussed previously)
notch-Sep-28-2010.ny (818 Bytes)