add build date to log

Edgar · February 21, 2012, 9:56pm

post 2.0.0
in audacity.h ~ line 41, make beta & “stable” lines end with TDATE like “alpha” does (which adds the BUILD date–and thus some commit version info); also change the trailing - (dash) to a space–it looks better IMVHO:
old:

#if IS_ALPHA
   #define AUDACITY_SUFFIX wxT("-alpha-") __TDATE__ 
#elif (IS_BETA)
   #define AUDACITY_SUFFIX    wxT("-beta") 
#else
   #define AUDACITY_SUFFIX    wxT("") // for a stable release
#endif

new:

#if IS_ALPHA
   #define AUDACITY_SUFFIX wxT("-alpha ") __TDATE__ 
#elif (IS_BETA)
   #define AUDACITY_SUFFIX    wxT("-beta ") __TDATE__ 
#else
   #define AUDACITY_SUFFIX    wxT(" ") __TDATE__ // for a stable release
#endif

Gale_Andrews · February 22, 2012, 2:33am

Can you say why? There is a policy not to release Audacity with the same version number and different contents (alphas are not strictly “releases”).

There may be a better case for having the date of releases shown on the Audacity downloads pages.

Gale

Edgar · February 22, 2012, 8:04am

The devs would really like to be able to ID the commit revision number for some bug reports. Search Bugzilla for “commit”–I asked if there was a way and got “No, but it sure would be nice”. Having the build date on the betas (the “stable” is well known but you might as well have it for the sake of completion) as you already do on the alphas (it is part of the string which gets put at the top of the log) would help pin it down to a single day. That way parsing the commits would be a whole lot simpler.

ragnar.jensen · February 22, 2012, 7:35pm

It is super easy to have Subversion doing it for you.

svn propset svn:keywords "[Rev|Id|Date|Author|URL]" file

Then add

$Rev|Id|Date|Author|URL $

to the file and commit.

$ vi myfile.txt

>   $Rev: $

$ svn ci -m 'Add revision id to file' myfile.txt
$ less myfile.txt

> $Rev: 768 $

Same with the other tags of Id, Date, Author, URL

–
Ragnar

Edgar · February 22, 2012, 8:43pm

I do not see how the user in the field can then tell the dev what the commit revision number is. I think your example adds a revision number to a source file; they want a revision number on the executable and a way the user can report it in a bug report.

ragnar.jensen · February 22, 2012, 8:54pm

If the source file in question is AboutDialog.cpp:

EDIT: Oops, I was too fast! That will only show the revision when AboutDialog.cpp was last changed.
You’ll need svnversion and a bit of external processing to get the global revision number into your file.

–
Ragnar

Edgar · February 23, 2012, 12:41am

That was my thought as well–the devs are not going to edit in something each commit. With adding the build date automatically they get very close and it shows in the Log.

Gale_Andrews · February 23, 2012, 3:44am

Bugzilla gives too many results for “commit”.

My recollection was that Leland and I wanted to add revision number (to alphas) and Vaughan (or someone) did not, even if it could be done.

But same question - don’t we know the commit number of a release? I do.

Gale

billw58 · February 23, 2012, 4:39am

Certainly, because of the freeze. But there will be nightlies going forward, right? And if those nightlies had at the top of the log the latest commit number, I’d know for sure what I’m testing.

As an aside, I can’t see the date/time stamp of commits in Google Code. All I can see is e.g. “Today (26 minutes ago)” or “Yesterday (27 hours ago)”. I can infer from that the UTC of the commit, I suppose, but having it displayed would be much easier, and deal with the issue that was raised when I commented on bug 334 http://bugzilla.audacityteam.org/show_bug.cgi?id=334#c45 .

– Bill

Gale_Andrews · February 23, 2012, 6:30am

Yes, and they will be alphas (I presume) which already have TDATE appended to AUDACITY_SUFFIX.

Yes and that was what I was asking for (for the nightlies) but it cannot currently be done. Ed’s change does not add the svn revision number anywhere.

Rather than look on Google Code Archive - Long-term storage for Google Code Project Hosting. , the answer would be to subscribe to audacity-svn_AT_googlegroups.com (or just look at it online ).

Gale

Edgar · February 23, 2012, 7:20am

True, it just extends the ability to tell the build date to beta (and “stable” though of little interest there). Deducing a nightly’s commit revision number from it’s build date is not too hard I would suppose.

In re. searching the Bugzilla, sorry , can be of little further help, I recall it as Richard but maybe Leland who bemoaned the lack.

waxcylinder · March 31, 2012, 3:10pm

BUMP - does this need trnsferring to Wiki>Pending Feature Requests?

Gale_Andrews · April 1, 2012, 2:27am

Build date is already added to alphas and is un-necessary for releases. It seems that it isn’t possible to programmatically add the svn revision number to About Audacity (and so to the top of the log). So I don’t think this is for PFR’s.

Of course the person packaging the “Nightly Builds” (myself for Windows and Paul for Mac) can manually add the svn revision number to the name of the file to be downloaded (or somewhere else). I don’t think it would be acceptable to manually mess with Audacity.h each time to get the revision number in About Audacity and log. Paul might be able to script the file name to also include the revision number - I’ll ask him.

Gale

waxcylinder · April 1, 2012, 9:50am

Thanks for the heads-up Gale.

Peter