Freeze fast approaching; warnings in src/ (as opposed to lib-src/) are considered as unacceptable; the patch is probably stale but all the fixes are easy to apply by hand; of the five downloaders of the patch, does anyone have a comment?
Most of these are covered in the previously attached patch…
SVN HEAD 13665:
Link warnings
winProjectsAudacityAboutDialog.obj Audacity warning LNK4075: ignoring '/EDITANDCONTINUE' due to '/SAFESEH' specification
winProjectsAudacityAboutDialog.obj Audacity warning LNK4075: ignoring '/EDITANDCONTINUE' due to '/SAFESEH' specification
winProjectssoundtouchmmx_optimized.obj soundtouch warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
winProjectssoundtouchmmx_optimized.obj soundtouch warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
File Line # Warning
srcaudioio.cpp 3590 warning C4701: potentially uninitialized local variable 'selected' used
srceffectsladspaladspaeffect.cpp 349 warning C4100: 'ID' : unreferenced formal parameter
srceffectsladspaladspaeffect.cpp 784 warning C4100: 'maxBlockSize' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 258 warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 308 warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 314 warning C4100: 'path' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 314 warning C4100: 'pm' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 320 warning C4100: 'ID' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 330 warning C4100: 'ID' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 331 warning C4100: 'path' : unreferenced formal parameter
srceffectslv2loadlv2.cpp 338 warning C4100: 'instance' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp 142 warning C4100: 'pm' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp 148 warning C4100: 'path' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp 165 warning C4100: 'ID' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp 166 warning C4100: 'path' : unreferenced formal parameter
srceffectsnyquistloadnyquist.cpp 173 warning C4100: 'instance' : unreferenced formal parameter
srceffectsnyquistNyquist.h 209 warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistNyquist.h 209 warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistnyquist.h 209 warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsnyquistnyquist.h 209 warning C4251: 'EffectNyquist::mDebugOutput' : class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'EffectNyquist'
srceffectsvamploadvamp.cpp 114 warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 209 warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 215 warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 215 warning C4100: 'pm' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 222 warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 236 warning C4100: 'ID' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 237 warning C4100: 'path' : unreferenced formal parameter
srceffectsvamploadvamp.cpp 244 warning C4100: 'instance' : unreferenced formal parameter
srceffectsvstvsteffect.cpp 554 warning C4100: 'ID' : unreferenced formal parameter
srceffectsVSTVSTEffect.cpp 2013 warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)
srceffectsvstvsteffect.cpp 2013 warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)
srcfileio.cpp 100 warning C4100: 'type' : unreferenced formal parameter
srcimagemanipulation.cpp 277 warning C4100: 'offset' : unreferenced formal parameter
srcimportimportmidi.cpp 72 warning C4706: assignment within conditional expression
srcmodulemanager.cpp 590 warning C4100: 'providerID' : unreferenced formal parameter
srcnotetrack.cpp 217 warning C4706: assignment within conditional expression
srcpluginmanager.cpp 1719 warning C4100: 'forceRescan' : unreferenced formal parameter
srcprefslibraryprefs.cpp 132 warning C4189: 'bfnd' : local variable is initialized but not referenced
srcprefslibraryprefs.cpp 138 warning C4189: 'bdwn' : local variable is initialized but not referenced
srctoolbarscontroltoolbar.cpp 619 warning C4100: 'p' : unreferenced formal parameter
srctrackpanelax.cpp 440 warning C4100: 'strValue' : unreferenced formal parameter
srctrackpanelax.cpp 440 warning C4100: 'childId' : unreferenced formal parameter
srcwidgetsgrid.cpp 93 warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp 93 warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp 93 warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp 93 warning C4100: 'row' : unreferenced formal parameter
srcwidgetsgrid.cpp 325 warning C4100: 'col' : unreferenced formal parameter
srcwidgetsgrid.cpp 325 warning C4100: 'row' : unreferenced formal parameter
srcwidgetsgrid.cpp 326 warning C4100: 'grid' : unreferenced formal parameter
srcwidgetsgrid.cpp 327 warning C4100: 'oldval' : unreferenced formal parameter
srcwidgetsgrid.cpp 873 warning C4100: 'childId' : unreferenced formal parameter